Add close() and context management to ubi_file
#89
Conversation
|
Could you provide a concise description of what this PR tries to achieve both in the PR description and in the git commit message ? Thanks :) |
Add a new method to ubi_file which currently doesn't have a way to close the underlying file handle. Use it in the scripts where a ubi_file instance is created. Context management allows for a cleaner way to work with ubi_file instances.
|
Didn't bother to write one because I think the title is pretty self-explanatory but here you go. I'm sure if you take a look at the few added lines you'll see what this PR does. |
There was a problem hiding this comment.
Code is okay. Minimal impact since the OS close the file handle anyway when the process exits (which happens immediately after the explicit close in modified scripts). Agreed that explicit closing is better though.
@vlaci ok to merge ?
|
BTW, I did some |
While waiting for the next version of ubireader that will have onekey-sec/ubi_reader#89, use a context manager to close the UBI file.
Add a new method to
ubi_filewhich currently doesn't have a way to close the underlying file handle. Use it in the scripts where instances are created.Context management allows for a cleaner way to work with
ubi_fileinstances.