Rust version support changes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenix uses a technique, called import from derivation, to acquire
details for a rust toolchain version: It looks-up the version number,
than downloads a manifest file, and build nix expressions from that
which will be imported at the end.
Nix flake check trips on IFD, with error messages like
> a 'aarch64-darwin' with features {} is required to build
'/nix/store/...', but I am a 'x86_64-linux' with features {}
Rust-overlay on the other hand ships with toolchain manifests, not
requiring IFD (but it is larger in size).
This problem is hidden at this moment, as the manifest from Rust 1.60
leaks into the nix store somehow on the builders.
It has been released in last November and is in use for `pyperscan` already, where that version is a hard requirement.
kukovecz
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.65 has been released in last November and is in use for
pyperscanalready, where that version is a hard requirement. It reduces the mental overhead, if we are working with the same versions.