Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Russian translation #139

Merged
merged 2 commits into from
Sep 19, 2020
Merged

Conversation

i-grou
Copy link

@i-grou i-grou commented Sep 8, 2020

Overview

This PR improves translation to Russian language. Many strings were literally translated, hence it was not sound good for native Russian speakers. Maybe not all of them are perfect now, but anyway it sounds much better now.

Comment

I could also provide translation to some strings that are not translated yet, but localisation file miss them. So it would be possible to do when issue #138 would be resolved.

@i-grou
Copy link
Author

i-grou commented Sep 10, 2020

@delano could you review?

@i-grou
Copy link
Author

i-grou commented Sep 18, 2020

@rugk, @chelnak, @kozmic, @webninjasi, @utter-step maybe you guys could review? :)
Is this project still maintained?

@rugk
Copy link

rugk commented Sep 18, 2020

No I cannot. I don't speak Russian. And even if, I could not merge it… 🙃

Regarding maintenance, it looks quite abandoned. I've opened an issue about that: #141

@delano
Copy link
Collaborator

delano commented Sep 18, 2020

Thanks @ivan-compucorp, yep still maintained. Just busy so thanks for pinging again.

If you'd like credit on the site, add you details at the top of list in the contributions template and push to this branch. Otherwise let me know and I'll go ahead and merge now. The changes will be included in the next release.

@i-grou
Copy link
Author

i-grou commented Sep 19, 2020

@delano could you point me the correct file? I've added myself to translations.mustache, but I guess there is some other file where I should add myself to the top of the list as you suggested.

@delano
Copy link
Collaborator

delano commented Sep 19, 2020

Ah, sorry I wasn't clear. I meant to say the list of contributors so yep, good to go. Thanks for helping make OTS better.

@delano delano merged commit e1156b1 into onetimesecret:master Sep 19, 2020
@i-grou i-grou deleted the improve-locale-ru branch September 19, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants