Simplify docker compose config #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to properly install system utilities and use the build container Signed-off-by: delano <delano@onetimesecret.com>
Signed-off-by: delano <delano@onetimesecret.com>
To properly use bin/entrypoint.sh and to mount the cwd inside the container to skip having to rebuild for every change Signed-off-by: delano <delano@onetimesecret.com>
Signed-off-by: delano <delano@onetimesecret.com>
delano
added
bug
improvement
dependencies
Signed-off-by: delano <delano@onetimesecret.com>
And added a `bundle install` to the entrypoint script so that we only need to restart the container rather than a full rebuild. Signed-off-by: delano <delano@onetimesecret.com>
Signed-off-by: delano <delano@onetimesecret.com>
* Switched to thin * Run the command via bundle exec * Mount the current working directory as $CODE_HOME * Add container names * Added redis volume to persist data Signed-off-by: delano <delano@onetimesecret.com>
sendgrid-ruby Signed-off-by: delano <delano@onetimesecret.com>
Signed-off-by: delano <delano@onetimesecret.com>
Signed-off-by: delano <delano@onetimesecret.com>
delano
force-pushed
the
delano/20230414-simplify-dc
branch
from
416f553
to
78a07d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
container.env.exampleappcontainer from.envcommand:setting in the docker-compose.yml file.stdin:andtty:are now both set to true. This makes it possible to attach and interact with a running container.