-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of Ruby 3.1+ Support and Pre-commit Configuration #293
Conversation
This commit adds a new file, `.pre-commit-config.yaml`, which contains the configuration for pre-commit hooks. The hooks include checks for trailing whitespace, end-of-file fixes, YAML syntax, detection of private keys, mixed line endings, large file additions, no commits to specific branches, merge conflict checks, and submodule forbiddance. Additionally, the commit adds the black hook for Python code formatting and the add-msg-issue-prefix hook for linking commits to GitHub issues.
Remove version locks from Gemfile to allow resolving latest versions. This upgrades the app to use current Ruby and Gem versions for improved security, performance, and stability.
Ruby 3.1+ support and preping for updated installation instructions
Questions to better understand the PR:
Please respond to the questions above in the following format:
|
/answer
|
This update introduces significant changes aimed at modernizing the codebase and enhancing code quality. The primary enhancement is the transition to Ruby 3.1+, indicated by the update in the README.md and Gemfile, where the Ruby version is explicitly set to '3.2.0'. This shift signifies a major update in the project's underlying technology, moving away from the previously supported Ruby versions up to 2.6.6.
More detail
Alongside the Ruby upgrade, the Gemfile has been simplified by removing version constraints on dependencies. This change suggests a move towards leveraging the latest versions of these gems, which could bring in improvements and new features from the gem updates. The introduction of the 'bundler-graph' plugin in the Gemfile is a minor but notable addition for visualizing the project's gem dependencies.
A significant new addition is the .pre-commit-config.yaml file, which introduces a pre-commit framework to the project. This framework is designed to improve code quality and consistency by automatically running checks before commits are finalized. The configuration includes hooks for trailing whitespace, end-of-file fixers, YAML syntax checks, private key detection, and more. This setup indicates a proactive approach to maintaining code quality and security.
The README.md file has been updated to reflect the new Ruby version support and removes detailed installation instructions, which are marked as "to be determined" (tbd). This change suggests an ongoing transition and adaptation to the new Ruby version's requirements.
In the Dockerfile, the base image has been updated from Ruby 2.6 to Ruby 3.1, aligning with the project's move to Ruby 3.1+ support. This change is crucial for ensuring that the Docker environment matches the project's updated Ruby version requirements.
Lastly, the deletion of migration files indicates a cleanup or restructuring of the database migration strategy. This could be part of the project's efforts to streamline or update its database schema management in line with the other updates.