[EMAIL] Improve email sending reliability and security #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change wraps all URLs in email templates with HTML <a> tags to make them clickable and improve usability for users accessing these emails across different mail clients. Links were added to all occurrences of base and internal URIs in welcome, password reset, secret sharing and test emails. This should help avoid confusion and allow direct navigation from the email content. Signed-off-by: delano <delano@onetimesecret.com>
- Obscure customer identifiers in rate limiting logs using a hashing function - Replace verbose debug logging with targeted error handling - Improve error messages for rate limiting exceptions Signed-off-by: delano <delano@onetimesecret.com>
Updates the email sending logic to extract the configuration into variables for easier maintenance and customization. Also wraps the delivery in a begin/rescue block to capture any errors. This avoids unintentionally failing silently and ensures proper reporting when emails cannot be sent. Signed-off-by: delano <delano@onetimesecret.com>
Email not working #280 E-mails are not being sent #285 - Avoid delivery failures by complying with sending platform requirements - Add reply-to address - Improve traceability with logging of from, to, subject at start of send - Facilitate troubleshooting by logging specific error types separately Signed-off-by: delano <delano@onetimesecret.com>
delano
added
security
ruby
|
PR Description updated to latest commit (0b514bc) |
PR Review
|
Signed-off-by: delano <delano@onetimesecret.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This pull request fixes the issue where emails are not being sent. It includes several improvements to the email functionality, such as wrapping URLs in email templates with HTML tags to make them clickable, improving log handling, fixing the reset password request logic, and addressing the email from address. These changes should ensure that emails are sent successfully and improve the overall email functionality.
Fixes #280, #285
Type
Bug fix
Changes walkthrough
base.rb
Improve error handling and logging in APIlib/onetime/app/api/base.rb
helpers.rb
Enhance rate limiting error handling and logginglib/onetime/app/helpers.rb
function