Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis connection timeout for redis-rb v5 #366

Conversation

delano
Copy link
Collaborator

@delano delano commented May 30, 2024

The Redis connection timeout has been removed from the configuration files to allow the Redis client to use its default timeout behavior. This prevents unwanted timeouts in case of temporary network issues or slower operations.

Additionally, the release recommendation in the README has been updated to point to the latest release instead of a specific release candidate. This change makes it easier for users to find and download the latest stable version of the software.

Fixes #365

The Redis connection URI in the configuration files has been updated
to remove the `timeout` parameter. Specifically:
- In `.env.example`, `REDIS_URL` no longer includes `?timeout=10`
- In `etc/config.example`, the `:uri` setting under `:redis` has the
  `?timeout=10` portion removed
- `etc/config.test` also has the `?timeout=10` removed from the Redis
  `:uri`

Removing the timeout parameter allows the Redis client to use its
default timeout behavior instead of forcing a 10 second timeout on all
operations. This change prevents unwanted timeouts in case of temporary
network issues or slower operations.
The `config.test` file has been removed as it was no longer being used
in the project.
Updates the recommendation to point to the latest release instead of a
specific release candidate. This change makes it easier for users to
find and download the latest stable version of the software.
@delano delano linked an issue May 30, 2024 that may be closed by this pull request
@delano delano changed the title Fix Redis connection timeout and update release recommendation Fix Redis connection timeout for redis-rb v5 May 30, 2024
@delano delano self-assigned this May 30, 2024
@delano delano added the Bug fix Issues or pull requests that involve fixing bugs. label May 30, 2024
@delano delano merged commit 028e0e1 into develop May 30, 2024
6 checks passed
@delano delano deleted the 365-string-integer-conversion-error-at-start-time-with-redis-rb-50 branch May 30, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Issues or pull requests that involve fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String->integer conversion error at start-time with redis-rb 5.0
1 participant