Fix NilClass error in Metadata#update_fields method

[delano]

User description

This pull request addresses the issue #441 where a NilClass error occurs in the Metadata#update_fields method. The error is caused by a nil value in the custid parameter. This fix ensures that the custid parameter is set to an empty string if it is nil, preventing the error from occurring.

---

PR Type

Bug fix, Dependencies

---

Description

• Fixed a NilClass error in the Metadata#update_fields method by ensuring custid is set to an empty string if nil.
• Updated familia gem version from '>= 0.10.1' to '~> 0.10.2'.

---

Changes walkthrough 📝

	Relevant files
Bug fix	metadata.rb Fix NilClass error in Metadata#update_fields method            lib/onetime/models/metadata.rb Fixed a NilClass error in the Metadata#update_fields method by ensuring custid is set to an empty string if nil. +1/-1
Dependencies	Gemfile Update `familia` gem version to 0.10.2                                      Gemfile Updated familia gem version from '>= 0.10.1' to '~> 0.10.2'. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	2
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The fix in metadata.rb ensures custid is set to an empty string if nil, which might not be the desired behavior in all cases. Consider if there are any side effects of this change, especially in methods that depend on custid.

[codiumai-pr-agent-pro]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Use fetch with a default value to handle potential nil values more explicitly Instead of using custid || '', consider using fetch with a default value to handle the case where custid might be nil. This approach is more explicit and avoids potential issues with falsy values. lib/onetime/models/metadata.rb [23] -hsh[:custid] ||= custid || '' # anything but nil, see #441 +hsh[:custid] ||= hsh.fetch(:custid, custid || '') Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion to use fetch provides a clearer and more explicit way to handle default values, which can improve code readability and prevent errors related to falsy values. However, the existing code already handles the case correctly, so the improvement is not critical.	7
Maintainability	Ensure consistent version constraint format for the familia gem Ensure that the version constraint for the familia gem is consistent with other gems by using the same format (>= instead of ~>), unless there is a specific reason to change it. Gemfile [34] -gem 'familia', '~> 0.10.2' +gem 'familia', '>= 0.10.2' Apply this suggestion Suggestion importance[1-10]: 4 Why: The suggestion is valid in terms of maintaining consistency in version constraints, but using ~> instead of >= can be intentional to avoid unexpected breaking changes from non-backward compatible updates. The suggestion does not consider the potential need for stricter version control.	4