Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFRA-779: add checking for Content-Type #5

Merged
merged 2 commits into from
Jul 25, 2019
Merged

INFRA-779: add checking for Content-Type #5

merged 2 commits into from
Jul 25, 2019

Conversation

HelgiCannoli
Copy link

Доработать shaker, чтобы он ругался на HTML in Response только в случае, если сам по себе ответ не JSON

@amgorb
Copy link

amgorb commented Jul 24, 2019

LGTM

tonymadbrain
tonymadbrain approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@tonymadbrain tonymadbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если честно, я не совсем понимаю, зачем мы вообще ругаемся на html в ответе, может от этого вообще надо избавиться или переделать. Код выглядит норм, если оно снимет чью-то боль, то я конечно ОК.

@tonymadbrain tonymadbrain merged commit 5d35a1c into onetwotrip:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amgorb amgorb amgorb approved these changes

@tonymadbrain tonymadbrain tonymadbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HelgiCannoli @amgorb @tonymadbrain