Stop module support #1523
Merged
Stop module support #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoduricg
pushed a commit
to rentpath/Kingfisher
that referenced
this pull request
Sep 24, 2021
Stop module support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a long-ago intended change since version 5.8. But at that time, Carthage fails to create valid cache hash when no ObjC header generated.
#1307
Now Carthage has fixed that issue, and it seems that Carthage built frameworks on Xcode 12 is failing at merging the headers from different frameworks when they have conflicting type names (#1517 and Alamofire/Alamofire#3303). So it seems that now it is another good chance to apply this.
It removes support of Objective-C so there would be no header conflicting anymore with another project. (Regardless of it being an Xcode issue or a Carthage issue.)