-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SessionDelegate naming conflict between Kingfisher and Alamofire in Xcode 12 GM #1517
Comments
I am having exactly the same problem with latest Xcode official release |
The same issue. |
Issue still exists in Xcode 12 official release. The only solution for now is to rename the "SessionDelegate" to "KFSessionDelegate" or something like that in Kingfisher module. |
I'll check what I can do for it. |
@sachajln @timbms @Senocico @alperkayabasi Can you confirm whether this branch "fix/no-objc" can solve your issue? If everything goes fine, I will merge it and tag a new version soon. Thanks! |
@onevcat Worked for me! Thanks. |
@onevcat Worked for me too, thank you. |
5.15.3 was released for this. |
hello @onevcat, i tried from cocoapod for version 5.15.3 has same problem with alamofire |
@KhairulRijl Which Alamofire version do you have in podfile? It worked for me with the latest release 5.2.2. |
@alperkayabasi now i'm using 4.9.0 version of alamofire for some reason, is there any problem with version 4 alamofire with kingfisher? |
@KhairulRijl My guess is Alamofire removed objc module support with version 5. So the problem still exists if you use v4. |
@onevcat is 5.15.3 already available via cocoapods? |
@alperkayabasi yes, the problem from v4 alamofire. after config build setting in cocoapods spesific for alamofire, change to No for objc module support, the problem is gone. thanks for your information. |
Check List
Issue Description
What
There seems to be a naming conflict inside the objc header file with the
SessionDelegate
class when using both Kingfisher and Alamofire in Xcode 12 GM. (You can see the issue on Alamofire side here, more discussion here)Reproduce
Use Alamofire and Kingfisher frameworks inside a project and do a
xcodebuild -project YOUR_PROJECT.xcodeproj -sdk iphoneos
with Xcode 12 GM command line tools.Comments
I'm using Carthage to build and copy the frameworks in my project
The text was updated successfully, but these errors were encountered: