Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #2

Merged
merged 6 commits into from Jul 8, 2022
Merged

Clean up #2

merged 6 commits into from Jul 8, 2022

Conversation

turbolent
Copy link
Member

  • Move tests to separate files
  • Improve analyzer names, e.g. make them consistent by removing analyzer/analysis suffix
  • Adjust redundant cast analyzer for FLIP 941

@turbolent turbolent self-assigned this Jun 30, 2022
dsainati1
dsainati1 approved these changes Jul 1, 2022
View reviewed changes
analyzers/redundant_cast_analyzer.go
@@ -191,7 +191,7 @@ func (d *CheckCastVisitor) VisitDestroyExpression(_ *ast.DestroyExpression) ast.
}

func (d *CheckCastVisitor) VisitReferenceExpression(_ *ast.ReferenceExpression) ast.Repr {
return d.isTypeRedundant(d.exprInferredType, d.targetType)
return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dsainati1
Copy link
Contributor

Since we are updating the analyzer to work with onflow/cadence#1661, should we update the version of Cadence in go.mod to point to a commit including those changes?

@turbolent turbolent merged commit 7256abe into master Jul 8, 2022
@turbolent turbolent deleted the bastian/cleanup branch July 8, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsainati1 dsainati1 dsainati1 approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

Assignees

@turbolent turbolent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turbolent @dsainati1