Improve reference expressions #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1661 +/- ##
=======================================
Coverage 77.43% 77.43%
=======================================
Files 305 305
Lines 62552 62546 -6
=======================================
- Hits 48437 48434 -3
+ Misses 12494 12492 -2
+ Partials 1621 1620 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 5a06fec Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Merged
5 tasks
SupunS
approved these changes
Jun 17, 2022
Comment on lines
6445
to
6446
| require.IsType(t, &sema.UnnecessaryCastHint{}, hints[0]) | ||
| castHint := hints[0].(*sema.UnnecessaryCastHint) |
SupunS
reviewed
Jun 20, 2022
|
Turns out, this also fixes a bug in the parser: https://github.com/onflow/cadence/pull/1661/files#diff-62e34e916aed6bc25eed273b0edbb3c0fc078de38bec85ed1fb4d034fc65b6cdR2428-R2429 Kudos to themasterpiece.art for reporting this bug. |
|
Merging, now that onflow/flow#941 has been accepted |
turbolent
added
the
Language Breaking Change
6 tasks
6 tasks
This was referenced Jul 20, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the FLIP proposing to improve reference expressions:
&v. This turns existing cases of&v as &Tinto a casting expression, a static type annotationas, a variable declaration type annotationThese changes essentially make references behave exactly like empty container literals (empty array
[]and empty dictionary{}), unifying the concepts and allowing the intuition that developers gained there to be applied for references, too.In addition it keeps all current code working as before.
masterbranchFiles changedin the Github PR explorer