Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments documentation #2212

Closed
alilloig opened this issue Jan 4, 2023 · 5 comments
Closed

Attachments documentation #2212

alilloig opened this issue Jan 4, 2023 · 5 comments
Assignees
Labels
Dev Portal Documentation Documentation Improvements or additions to documentation Feedback Improvement SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board

Comments

@alilloig
Copy link
Member

alilloig commented Jan 4, 2023

Issue To Be Solved

We need to include the new attachments FLIP on the dev portal docs

Suggested Solution

Create a new section in the language docs, explaining and giving examples on how to use it https://github.com/onflow/flips/blob/main/cadence/2022-09-21-attachments.md

@alilloig alilloig added the SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board label Jan 4, 2023
@alilloig
Copy link
Member Author

alilloig commented Jan 4, 2023

@turbolent maybe y'all are already tracking this, we are about to write the first feature using attachments so we though it could be a good timing to include it to the docs

@turbolent turbolent assigned dsainati1 and unassigned turbolent Jan 4, 2023
@dsainati1
Copy link
Contributor

#2137 already adds documentation for attachments to the attachments feature branch; when this feature branch is merged to master this documentation should be added to the website.

@dsainati1
Copy link
Contributor

Other than this, I believe we had been discussing updating the Cadence tutorials to include a new tutorial on attachments in this issue: onflow/flow-playground-tutorials#16

@turbolent
Copy link
Member

@alilloig Like Daniel pointed out, there are docs, they are not merged yet, because the feature hasn't been merged yet. If you need the docs, they're here:
https://github.com/onflow/cadence/blob/feature/attachments/docs/language/attachments.md

@alilloig
Copy link
Member Author

alilloig commented Jan 4, 2023

Thank you so much guys! Yeah having the docs will be great, we were looking at the flip.

@alilloig alilloig closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Portal Documentation Documentation Improvements or additions to documentation Feedback Improvement SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board
Projects
None yet
Development

No branches or pull requests

3 participants