Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments Documentation #2137

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Attachments Documentation #2137

merged 5 commits into from
Dec 12, 2022

Conversation

dsainati1
Copy link
Contributor

Closes #357

Documentation for the attachments feature

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@dsainati1 dsainati1 added the Documentation Improvements or additions to documentation label Nov 15, 2022
@dsainati1 dsainati1 self-assigned this Nov 15, 2022
@dsainati1 dsainati1 marked this pull request as ready for review December 12, 2022 18:48
Base automatically changed from sainati/attachment-declaration-interpreting to feature/attachments December 12, 2022 19:09
@dsainati1 dsainati1 merged commit fab8da2 into feature/attachments Dec 12, 2022
@dsainati1 dsainati1 mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamsmasher dreamsmasher Awaiting requested review from dreamsmasher

@turbolent turbolent Awaiting requested review from turbolent

@SupunS SupunS Awaiting requested review from SupunS

@joshuahannan joshuahannan Awaiting requested review from joshuahannan

Assignees

@dsainati1 dsainati1

Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsainati1 @bthaile