Use common super-type for expression type inferring #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
force-pushed
the
supun/common-supertype-3
branch
2 times, most recently
from
b0d42b2
to
5ca55cb
Compare
SupunS
force-pushed
the
supun/common-supertype-usages
branch
from
6ce5a41
to
ea32ec5
Compare
SupunS
force-pushed
the
supun/common-supertype-usages
branch
from
ca1a55e
to
d362440
Compare
SupunS
added
the
Language Breaking Change
SupunS
force-pushed
the
supun/common-supertype-usages
branch
from
d39e167
to
cc3c169
Compare
SupunS
force-pushed
the
supun/common-supertype-usages
branch
from
cc3c169
to
8a5de64
Compare
SupunS
force-pushed
the
supun/common-supertype-3
branch
from
351fdf6
to
56f6e53
Compare
…cadence into supun/common-supertype-usages
SupunS
commented
Nov 6, 2021
| @@ -233,41 +231,6 @@ func (checker *Checker) recordVariableDeclarationRange( | |||
| ) | |||
| } | |||
|
|
|||
| func (checker *Checker) checkVariableDeclarationUsability(declaration *ast.VariableDeclaration) { | |||
There was a problem hiding this comment.
This check now happens at the expression level for arrays/dictionaries. Because:
- Need to infer the type even in non-variable-delectation scenarios. e.g: the expression
[].getType()should have a type inferred for the empty array. - Even if the array is not empty, there could be non-inferrable scenarios
e.g:[<some_struct>, <some_resource>]
…cadence into supun/common-supertype-usages
…/common-supertype-usages
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 81f00f2 Results
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
+ Coverage 77.53% 77.59% +0.06%
==========================================
Files 274 274
Lines 35085 35241 +156
==========================================
+ Hits 27204 27347 +143
- Misses 6801 6809 +8
- Partials 1080 1085 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Bastian Müller <bastian@axiomzen.co>
…flow/cadence into supun/common-supertype-usages
SupunS
force-pushed
the
supun/common-supertype-usages
branch
from
da9d200
to
a961aae
Compare
14 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
Closes #1239
Description
This PR adds support for inferring the common supertype for:
Breaking Changes
With these changes, array literals and dictionary literals no longer use the first element to infer the type for the literal. Thus, if it requires a literal to have a certain specific type, then explicit type annotation or casting must be used.
e.g:
Old way
New Way
masterbranchFiles changedin the Github PR explorer