Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.23] Detect breaking changes #1607

Merged
merged 39 commits into from
Jun 16, 2022
Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Apr 26, 2022

Work towards https://github.com/dapperlabs/cadence-private-issues/issues/43

Description

Add an analyzer tool which detects most breaking changes of Secure Cadence:

Breaking changes which are statically detectable:

Breaking changes which cannot be detected statically, but can be hinted at:


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent force-pushed the bastian/43-breaking-changes-analysis branch from a6ef85a to afc1e51 Compare April 26, 2022 17:42
@turbolent turbolent force-pushed the bastian/43-breaking-changes-analysis branch from cef78bc to 0cfa676 Compare April 26, 2022 21:45
@turbolent turbolent changed the title Detect breaking changes [0.23] Detect breaking changes Apr 26, 2022
@turbolent turbolent marked this pull request as ready for review April 26, 2022 23:16
@turbolent turbolent requested a review from SupunS as a code owner April 26, 2022 23:16
@turbolent turbolent force-pushed the bastian/43-breaking-changes-analysis branch from bf0ffd0 to 6f4298d Compare April 26, 2022 23:50
@turbolent
Copy link
Member Author

  • Added documentation / README
  • Fixed analyzers
  • Added more analyzers
  • Added support for analyzing contracts of network accounts

@turbolent
Copy link
Member Author

turbolent commented May 4, 2022

Made a few improvements:

Could you please have another look at the recently added commits @SupunS and @dsainati1?
Once approved, I'll create a new release for the tool

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the most recent commits. LGTM!

Base automatically changed from bastian/1269-improve-analysis to v0.23 June 16, 2022 23:07
@turbolent turbolent merged commit f74126f into v0.23 Jun 16, 2022
@turbolent turbolent deleted the bastian/43-breaking-changes-analysis branch June 16, 2022 23:26
@turbolent turbolent mentioned this pull request Jun 17, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants