Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero-pad string representation of addresses #1214

Merged
merged 1 commit into from Nov 4, 2021

Conversation

turbolent
Copy link
Member

Closes #1131


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added Language Breaking Change Breaks Cadence contracts deployed on Mainnet Improvement labels Nov 3, 2021
@turbolent turbolent self-assigned this Nov 3, 2021
Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@turbolent turbolent force-pushed the bastian/1131-zero-pad-address branch from 07b4e8c to dfc3fb4 Compare November 3, 2021 16:03
@codecov-commenter
Copy link

Codecov Report

Merging #1214 (07b4e8c) into master (2b9ff0d) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 07b4e8c differs from pull request most recent head dfc3fb4. Consider uploading reports for the commit dfc3fb4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
+ Coverage   76.91%   77.13%   +0.22%     
==========================================
  Files         272      272              
  Lines       33887    33912      +25     
==========================================
+ Hits        26065    26159      +94     
+ Misses       6724     6691      -33     
+ Partials     1098     1062      -36     
Flag Coverage Δ
unittests 77.13% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/common/address.go 92.30% <100.00%> (+0.30%) ⬆️
runtime/common/addresslocation.go 81.39% <100.00%> (ø)
runtime/format/address.go 100.00% <100.00%> (ø)
runtime/sema/check_composite_declaration.go 96.01% <100.00%> (+0.02%) ⬆️
runtime/interpreter/conversion.go 95.12% <0.00%> (ø)
runtime/sema/type.go 87.66% <0.00%> (+0.12%) ⬆️
runtime/interpreter/value.go 82.31% <0.00%> (+1.48%) ⬆️
runtime/sema/ordered_map_string_type.go 55.81% <0.00%> (+9.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9ff0d...dfc3fb4. Read the comment docs.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Language Breaking Change Breaks Cadence contracts deployed on Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero-padding of Address#toString()
4 participants