Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow-docs.json to include "why cadence" section. #2040

Merged
merged 3 commits into from Oct 21, 2022

Conversation

10thfloor
Copy link
Contributor

@10thfloor 10thfloor commented Oct 6, 2022

Description

Adds header CTA to new "why Cadence" section on the Cadence homepage:
https://developer.flow.com/cadence/why


  • Targeted PR against master branch
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@10thfloor 10thfloor changed the title Update flow-docs.json to include "why Cadence" section. Update flow-docs.json to include "why cadence" section. Oct 6, 2022
docs/flow-docs.json Outdated Show resolved Hide resolved
docs/flow-docs.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #2040 (43d445a) into master (0c5d3e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2040   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files         303      303           
  Lines       63164    63164           
=======================================
  Hits        49024    49024           
  Misses      12394    12394           
  Partials     1746     1746           
Flag Coverage Δ
unittests 77.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0c5d3e5
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2153µs ± 3%155µs ±10%~(p=1.000 n=6+7)
ContractInterfaceFungibleToken-249.1µs ± 4%49.6µs ± 3%~(p=0.318 n=7+7)
InterpretRecursionFib-22.74ms ± 2%2.73ms ± 2%~(p=0.628 n=7+6)
NewInterpreter/new_interpreter-21.50µs ± 6%1.46µs ± 3%~(p=0.181 n=7+6)
NewInterpreter/new_sub-interpreter-2947ns ±12%873ns ± 2%~(p=0.138 n=7+6)
ParseArray-29.41ms ± 3%9.71ms ± 9%~(p=0.445 n=6+7)
ParseDeploy/byte_array-214.3ms ± 5%14.5ms ± 8%~(p=0.710 n=7+7)
ParseDeploy/decode_hex-21.48ms ± 4%1.47ms ± 3%~(p=0.902 n=7+7)
ParseFungibleToken/With_memory_metering-2222µs ± 1%227µs ± 7%~(p=0.534 n=6+7)
ParseFungibleToken/Without_memory_metering-2178µs ±12%175µs ± 5%~(p=1.000 n=7+7)
ParseInfix-28.13µs ± 6%8.17µs ± 4%~(p=0.456 n=7+7)
QualifiedIdentifierCreation/One_level-22.93ns ± 3%2.91ns ± 3%~(p=0.902 n=7+7)
QualifiedIdentifierCreation/Three_levels-2169ns ± 2%172ns ± 5%~(p=0.318 n=7+7)
RuntimeFungibleTokenTransfer-2808µs ±19%771µs ±30%~(p=0.383 n=7+7)
RuntimeResourceDictionaryValues-26.16ms ± 4%6.01ms ± 2%~(p=0.128 n=7+7)
RuntimeScriptNoop-226.1µs ±29%25.8µs ±30%~(p=0.902 n=7+7)
ValueIsSubtypeOfSemaType-2115ns ± 4%111ns ± 5%−4.13%(p=0.022 n=6+7)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-251.0kB ± 0%51.0kB ± 0%~(all equal)
ContractInterfaceFungibleToken-224.2kB ± 0%24.2kB ± 0%~(all equal)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(all equal)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2264B ± 0%264B ± 0%~(all equal)
ParseArray-22.75MB ± 0%2.68MB ± 3%−2.58%(p=0.015 n=6+6)
ParseDeploy/byte_array-24.25MB ± 4%4.19MB ± 3%~(p=0.710 n=7+7)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=0.322 n=6+7)
ParseFungibleToken/With_memory_metering-229.4kB ± 0%29.4kB ± 0%~(p=0.286 n=7+7)
ParseFungibleToken/Without_memory_metering-229.4kB ± 0%29.4kB ± 0%~(p=0.559 n=7+7)
ParseInfix-21.93kB ± 0%1.93kB ± 0%~(p=0.446 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeFungibleTokenTransfer-2103kB ± 1%103kB ± 1%~(p=0.383 n=7+7)
RuntimeResourceDictionaryValues-22.27MB ± 0%2.27MB ± 0%~(p=0.535 n=7+7)
RuntimeScriptNoop-28.83kB ± 0%8.83kB ± 0%~(p=0.780 n=7+5)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2915 ± 0%915 ± 0%~(all equal)
ContractInterfaceFungibleToken-2436 ± 0%436 ± 0%~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-214.0 ± 0%14.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-25.00 ± 0%5.00 ± 0%~(all equal)
ParseArray-269.6k ± 0%69.6k ± 0%~(p=1.000 n=7+6)
ParseDeploy/byte_array-2104k ± 0%104k ± 0%~(p=0.694 n=7+7)
ParseDeploy/decode_hex-275.0 ± 0%75.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-21.00k ± 0%1.00k ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-21.00k ± 0%1.00k ± 0%~(all equal)
ParseInfix-260.0 ± 0%60.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeFungibleTokenTransfer-22.06k ± 0%2.06k ± 0%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-236.9k ± 0%36.9k ± 0%~(p=0.365 n=7+7)
RuntimeScriptNoop-2145 ± 0%145 ± 0%~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

@turbolent turbolent merged commit 2437fba into master Oct 21, 2022
@turbolent turbolent deleted the mk/update-cadence-homepage branch October 21, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants