Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename why-cadence.md to why.md to fix broken link #2102

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

j1010001
Copy link
Member

@j1010001 j1010001 commented Oct 27, 2022

Fixing #2039 which had incorrect name of a link referenced in #2040


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #2102 (f3146d8) into master (4ba4651) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files         303      303           
  Lines       63313    63313           
=======================================
  Hits        49192    49192           
  Misses      12364    12364           
  Partials     1757     1757           
Flag Coverage Δ
unittests 77.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 4ba4651
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2118µs ± 1%122µs ± 8%~(p=0.234 n=6+7)
ContractInterfaceFungibleToken-240.7µs ± 2%40.8µs ± 1%~(p=0.485 n=6+6)
InterpretRecursionFib-22.35ms ± 2%2.36ms ± 1%~(p=0.073 n=6+7)
NewInterpreter/new_interpreter-21.16µs ± 1%1.16µs ± 2%~(p=0.669 n=6+6)
NewInterpreter/new_sub-interpreter-2615ns ± 1%618ns ± 1%~(p=0.148 n=7+6)
ParseArray-28.18ms ± 1%8.19ms ± 1%~(p=0.836 n=7+6)
ParseDeploy/byte_array-212.3ms ± 2%12.4ms ± 2%~(p=0.295 n=7+6)
ParseDeploy/decode_hex-21.23ms ± 4%1.22ms ± 1%~(p=0.945 n=7+6)
ParseFungibleToken/With_memory_metering-2189µs ± 1%189µs ± 3%~(p=1.000 n=7+7)
ParseFungibleToken/Without_memory_metering-2150µs ± 0%150µs ± 0%~(p=1.000 n=7+7)
ParseInfix-27.18µs ± 1%7.18µs ± 1%~(p=0.836 n=7+6)
QualifiedIdentifierCreation/One_level-22.34ns ± 0%2.35ns ± 0%~(p=0.721 n=6+7)
QualifiedIdentifierCreation/Three_levels-2140ns ± 3%139ns ± 1%~(p=0.374 n=7+6)
RuntimeFungibleTokenTransfer-2555µs ±25%616µs ±18%~(p=0.128 n=7+7)
RuntimeResourceDictionaryValues-25.08ms ± 1%5.08ms ± 1%~(p=1.000 n=7+7)
RuntimeScriptNoop-218.3µs ±31%17.9µs ±26%~(p=0.776 n=7+7)
ValueIsSubtypeOfSemaType-294.3ns ± 2%95.8ns ± 5%~(p=0.318 n=7+7)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-250.1kB ± 0%50.1kB ± 0%~(p=0.462 n=7+7)
ContractInterfaceFungibleToken-224.2kB ± 0%24.2kB ± 0%~(p=0.462 n=7+7)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(p=0.140 n=7+6)
NewInterpreter/new_interpreter-2800B ± 0%800B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2216B ± 0%216B ± 0%~(all equal)
ParseArray-22.77MB ± 4%2.70MB ± 2%~(p=0.366 n=7+7)
ParseDeploy/byte_array-24.18MB ± 3%4.23MB ± 3%~(p=0.067 n=7+7)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=0.339 n=7+7)
ParseFungibleToken/With_memory_metering-229.4kB ± 0%29.4kB ± 0%~(p=0.175 n=6+7)
ParseFungibleToken/Without_memory_metering-229.4kB ± 0%29.4kB ± 0%~(p=1.000 n=7+7)
ParseInfix-21.93kB ± 0%1.93kB ± 0%~(p=0.647 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeFungibleTokenTransfer-2102kB ± 1%102kB ± 1%~(p=0.383 n=7+7)
RuntimeResourceDictionaryValues-22.27MB ± 0%2.27MB ± 0%~(p=0.165 n=7+7)
RuntimeScriptNoop-28.75kB ± 1%8.69kB ± 0%~(p=0.445 n=7+6)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2900 ± 0%900 ± 0%~(all equal)
ContractInterfaceFungibleToken-2434 ± 0%434 ± 0%~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-24.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-269.6k ± 0%69.6k ± 0%~(p=0.172 n=6+7)
ParseDeploy/byte_array-2104k ± 0%104k ± 0%~(p=0.266 n=7+7)
ParseDeploy/decode_hex-275.0 ± 0%75.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-20.99k ± 0%0.99k ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-20.99k ± 0%0.99k ± 0%~(all equal)
ParseInfix-260.0 ± 0%60.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeFungibleTokenTransfer-22.05k ± 0%2.05k ± 0%~(all equal)
RuntimeResourceDictionaryValues-236.9k ± 0%36.9k ± 0%~(p=0.188 n=7+7)
RuntimeScriptNoop-2141 ± 0%141 ± 0%~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

@turbolent
Copy link
Member

Please follow the checklist, e.g. the issue has no label

@j1010001 j1010001 added the Documentation Improvements or additions to documentation label Nov 1, 2022
@j1010001 j1010001 merged commit 8f35c49 into master Nov 1, 2022
@turbolent turbolent deleted the jan-rename-why-cadence branch January 3, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants