[v0.31] Enforce account links to be private #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the linkAccount function parameter type to PrivatePath
turbolent
requested review from
SupunS,
dsainati1 and
joshuahannan
as code owners
6 tasks
SupunS
approved these changes
Mar 3, 2023
Codecov Report
@@ Coverage Diff @@
## v0.31.5-account-link-improvements #2369 +/- ##
==================================================================
Coverage 77.70% 77.70%
==================================================================
Files 309 309
Lines 65798 65798
==================================================================
Hits 51129 51129
Misses 12889 12889
Partials 1780 1780
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:v0.31.5-account-link-improvements commit 9cf44e2 Collapsed results for better readability
|
dsainati1
approved these changes
Mar 6, 2023
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Mar 6, 2023
3997: Update Cadence to v0.31.5-account-link-improvements r=turbolent a=turbolent Diff: onflow/cadence@v0.31.5-account-link-pragma...v0.31.5-account-link-improvements - Emit an event when an account is linked - onflow/cadence#2370 - onflow/cadence#2368 - Enforce account links to be private - onflow/cadence#2369 - onflow/cadence#2366 Co-authored-by: Bastian Müller <bastian@axiomzen.co>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Mar 6, 2023
3997: Update Cadence to v0.31.5-account-link-improvements r=turbolent a=turbolent Diff: onflow/cadence@v0.31.5-account-link-pragma...v0.31.5-account-link-improvements - Emit an event when an account is linked - onflow/cadence#2370 - onflow/cadence#2368 - Enforce account links to be private - onflow/cadence#2369 - onflow/cadence#2366 Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #2366 to v0.31
masterFiles changedin the Github PR explorer