Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.31] Emit an event when an account is linked #2370

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Mar 3, 2023

Port of #2368 to v0.31


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #2370 (9cf44e2) into v0.31.5-account-link-improvements (1dbc566) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cf44e2 differs from pull request most recent head 0a85af7. Consider uploading reports for the commit 0a85af7 to get more accurate results

@@                        Coverage Diff                         @@
##           v0.31.5-account-link-improvements    #2370   +/-   ##
==================================================================
  Coverage                              77.70%   77.70%           
==================================================================
  Files                                    309      309           
  Lines                                  65798    65798           
==================================================================
  Hits                                   51129    51129           
  Misses                                 12889    12889           
  Partials                                1780     1780           
Flag Coverage Δ
unittests 77.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Base automatically changed from bastian/v0.31-private-account-links to v0.31.5-account-link-improvements March 6, 2023 15:45
@turbolent turbolent closed this Mar 6, 2023
@turbolent turbolent reopened this Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Cadence Benchstat comparison

This branch with compared with the base branch onflow:v0.31.5-account-link-improvements commit 954b359
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit 01d69d2 into v0.31.5-account-link-improvements Mar 6, 2023
@turbolent turbolent deleted the bastian/v0.31-account-linked-event branch March 6, 2023 16:04
bors bot added a commit to onflow/flow-go that referenced this pull request Mar 6, 2023
3997: Update Cadence to v0.31.5-account-link-improvements r=turbolent a=turbolent

Diff: onflow/cadence@v0.31.5-account-link-pragma...v0.31.5-account-link-improvements

- Emit an event when an account is linked 
  - onflow/cadence#2370
  - onflow/cadence#2368
- Enforce account links to be private
  - onflow/cadence#2369
  - onflow/cadence#2366


Co-authored-by: Bastian Müller <bastian@axiomzen.co>
bors bot added a commit to onflow/flow-go that referenced this pull request Mar 6, 2023
3997: Update Cadence to v0.31.5-account-link-improvements r=turbolent a=turbolent

Diff: onflow/cadence@v0.31.5-account-link-pragma...v0.31.5-account-link-improvements

- Emit an event when an account is linked 
  - onflow/cadence#2370
  - onflow/cadence#2368
- Enforce account links to be private
  - onflow/cadence#2369
  - onflow/cadence#2366


Co-authored-by: Bastian Müller <bastian@axiomzen.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants