Fixed getChainIdDefault() race condition #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c39de9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
force-pushed
the
jribbink/chainid-race-condition
branch
from
ff92ca3
to
17ee594
Compare
chasefleming
requested changes
May 15, 2023
yeah, my bad |
JeffreyDoyle
previously requested changes
May 16, 2023
|
Thanks, this was causing also problems with some bundlers |
jribbink
force-pushed
the
jribbink/chainid-race-condition
branch
from
1c68096
to
2f554b3
Compare
|
Sorry, added the tests now. I had to break the watcher function out into a separate file to write tests with mocks. Also just renamed |
jribbink
force-pushed
the
jribbink/chainid-race-condition
branch
2 times, most recently
from
7225901
to
1530845
Compare
jribbink
force-pushed
the
jribbink/chainid-race-condition
branch
from
1530845
to
3c39de9
Compare
chasefleming
approved these changes
May 16, 2023
| import {setChainIdDefault} from "./get-chain-id" | ||
|
|
||
| /** | ||
| * @description |
jribbink
dismissed
JeffreyDoyle’s stale review
stale review, tests have been added
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1641