Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jest on node v18.16.0 #1654

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix Jest on node v18.16.0 #1654

merged 1 commit into from
May 22, 2023

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented May 19, 2023

Addresses: #1653

We were running into this issue nodejs/node#47563. Removing the "window" global appears to be sufficient to fix this.

@jribbink jribbink requested a review from a team as a code owner May 19, 2023 22:23
@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

⚠️ No Changeset found

Latest commit: e1f51a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jribbink jribbink linked an issue May 19, 2023 that may be closed by this pull request
@chasefleming chasefleming merged commit 784b297 into master May 22, 2023
@chasefleming chasefleming deleted the jribbink/fix-jest-node-18 branch May 22, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Support Node 18
2 participants