-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLIP - Interaction Templates v1.1.0 #77
Conversation
Should we consider changing the way pins are generated as well here to be debth first since we are creating a new version? I think the pin should be sha3(your_code, sha3(dep1), sha3(dep2)) or something like that so if you have done sha3(dep1) you can memoize that for all FLIX. Or even cache it. |
After finding out about this from @bjartek, I am posting here the original message from a relevant message on Flow's discord:
We would like, if it's somehow possible, to have https://github.com/onflow/flow-interaction-template-tools/tree/master/cli integrated in |
@m-Peter I think this could be an improvement to an existing solution that is currently lacking. The way I see is we have to solve this problem for any transaction or script, then after we solve the mapping we can improve the mapping for flix templates by integrating into flix. I don't see the other way around to be better. |
Support new import syntax: In order to be consistent across all flow tools, it would be beneficial for flix to support new import syntax. This syntax does not have a contract address placeholder in the cadence code. It uses Pervious version:
New version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates according to feedback from the Interaction Template working group on August 14 2023
…oftware engineering definitions, argument has to do with value passed to methods and functions, not the name of the variables of methods and functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding comments from working group Nov 9
Update Authors
Use standard markdown header
…nce body and networks, add examples
Hello all! As per the FLIX Working Group's previous meeting on November 9th 2023, the group has aligned on the following updates to the FLIX specification to be included in version 1.1:
The following updates are reflected in the FLIP as of the date of this comment (Nov 14 2023). Please let us know if you have any thoughts or feedback! -- If you're not in the FLIX working group and would like to be, please feel free to send an email to wallet-wg@flow.com and we will include you in the following meeting invites! 😄 |
lgtm Co-authored-by: Bjarte S. Karlsen <bjarte@bjartek.org>
Co-authored-by: Jeff Doyle <jeffrey.doyle@dapperlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
congrates, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg2G
Merging as accepted as per the decision in the FLIX working group on Nov 21 🎉 |
FLIP - Interaction Templates v1.1.0
Overview
This update to the InteractionTemplate and InteractionTemplateInterface data structures is the result of the need to better define the order of various properties of the InteractionTemplate and InteractionTemplateInterface, for use during the serialization process required for ID generation.
This change uses JSON Arrays to express the order of certain elements of the InteractionTemplate and InteractionTemplateInterface, instead of Objects as we're previously used which do not have a notion of order.
Required updates