Don't create machine accounts for non-consensus or collection nodes #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyDoyle
approved these changes
Sep 9, 2021
|
@jordanschalm @kc1116 Can you check out this PR instead? This includes the QC fix as well as a staking collection update for a machine account bug |
jordanschalm
approved these changes
Sep 9, 2021
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Sep 17, 2021
1278: Update core-contracts version `v0.7.7->v0.7.9` r=jordanschalm a=jordanschalm Integrate a critical bug-fix on the `FlowClusterQC` contract from onflow/flow-core-contracts#244 Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241
Ignores votes that have not been submitted for qc and adds a test case for this
Only call create machine account function if the node is collection or consensus so the account that is registering doesn't have to pay account creation fees