Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core-contracts version v0.7.7->v0.7.9 #1278

Merged
merged 7 commits into from Sep 17, 2021

Conversation

jordanschalm
Copy link
Member

Integrate a critical bug-fix on the FlowClusterQC contract from onflow/flow-core-contracts#244

This new version includes a critical bug fix for the FlowClusterQC
contract
@kc1116
Copy link
Contributor

kc1116 commented Sep 13, 2021

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #1278 (05adb8f) into master (75dee2c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
- Coverage   54.83%   54.80%   -0.03%     
==========================================
  Files         502      502              
  Lines       31851    31852       +1     
==========================================
- Hits        17467    17458       -9     
- Misses      12027    12038      +11     
+ Partials     2357     2356       -1     
Flag Coverage Δ
unittests 54.80% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fvm/bootstrap.go 74.04% <100.00%> (+0.05%) ⬆️
module/mempool/epochs/transactions.go 94.73% <0.00%> (-5.27%) ⬇️
...sus/approvals/assignment_collector_statemachine.go 42.30% <0.00%> (-4.81%) ⬇️
...ngine/common/synchronization/finalized_snapshot.go 68.75% <0.00%> (-4.17%) ⬇️
engine/collection/synchronization/engine.go 62.90% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75dee2c...05adb8f. Read the comment docs.

@jordanschalm
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 17, 2021
@bors
Copy link
Contributor

bors bot commented Sep 17, 2021

@jordanschalm
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 17, 2021

@bors bors bot merged commit 6b18761 into master Sep 17, 2021
@bors bors bot deleted the jordan/hf/update-core-contracts branch September 17, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants