SoR History update #416
SoR History update #416
Conversation
Move backfill updates to new Backfiller resource
| // - `blockHeight` is the height where the backfill happened, it also defines the SoR used to backfill | ||
| // - `gapStartHeight` is the height of the first backfilled entry | ||
| // - `count` is the number of backfilled entries | ||
| // Note that in very rare cases, the backfilled gap may not be contiguous. This event does not |
There was a problem hiding this comment.
The reason for adding 2 events and not only RandomHistoryBackfilled is the edge case specifically mentioned in the comment.
If that edge case happens while only emitting RandomHistoryBackfilled, there is no clear way to know what exact indices got backfilled.
There was a problem hiding this comment.
I copied the suggested event definition from https://github.com/bluesign/flow-core-contracts/blob/randomBackfill/contracts/RandomBeaconHistory.cdc
|
Are you planning on doing this upgrade before or after Cadence 1.0? If the answer is after, I would prefer that you make these changes based on the |
I don't know exactly when Cadence 1.0 will be on MN. This PR change should go as soon as the the PR is merged to fix a current on-chain issue, so I guess it's gonna be before Cadence 1.0 |
tarakby
force-pushed
the
tarak/fix-sor-history
branch
from
f84ef5c
to
8b78cad
Compare
Move correct SoR index discovery to Backfiller resource
contracts/RandomBeaconHistory.cdc
Outdated
| // cache the array length in a local variable to avoid multiple calls to `length` | ||
| // when the array is too large | ||
| var arrayLength = UInt64(RandomBeaconHistory.randomSourceHistory.length) | ||
|
|
||
| // if a new gap is detected, emit an event | ||
| if correctIndex > arrayLength { |
There was a problem hiding this comment.
I confirmed with @turbolent in a discord thread that getting an array's length via arr.length is constant time, so seems this comment's content isn't a concern as I thought it might be earlier.
There was a problem hiding this comment.
Since accessing the length is constant time and cheap, I added this minor optimization FYI e913f3a
tarakby
force-pushed
the
tarak/fix-sor-history
branch
from
f48385c
to
9e5d257
Compare
tarakby
force-pushed
the
tarak/fix-sor-history
branch
from
9e5d257
to
75d3500
Compare
|
@joshuahannan can you please have a look? I think the PR can only be merged after your approval. |
There was a problem hiding this comment.
After we merge this, you'll need to make an upgrade plan and post it in a forum post like we've done for previous upgrades.
Then you'll also need to make a branch based off of the stable-cadence branch that includes these changes so that we can make sure the upgrades are working properly in the Cadence 1.0 migrations.
closes #414
The implementation:
backfillerresource to track and backfill past empty entries in the array