New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoR History update #416
Merged
Merged
SoR History update #416
Changes from 12 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
9bc1dd8
first update to handle possible gaps in history
tarakby 744408c
extend tests to cover single gap case
tarakby 2f4b0ab
update getRandomSourceHistoryPage and add tests for backfilled pages
tarakby 9e9e023
add test for non-contiguous gap edge case
tarakby 10e8d20
enforce minimum source length
tarakby 246804f
add RandomBeaconHistory.Backfiller and integrate with SoR commitment
sisyphusSmiling 0372751
bump Flow CLI version in CI workflow
sisyphusSmiling f0c9b2e
Merge pull request #417 from onflow/giovanni/update-fix-sor-history
tarakby e2094e7
simplify the backfilling logic
tarakby b875b63
update gapStartIndex init value
tarakby 322eff1
add event for missing and backfilled SoRs
tarakby fb153e2
update assets
tarakby c5b9d92
set and get for the backfiller limit
tarakby a9c658e
add a note about the hash output size
tarakby 8b78cad
reduce calls to the large array length
tarakby 178b5ef
go generate
tarakby bf7d1da
move all backfilling logic inside the backfiller resource
tarakby 0580a8a
move correct index discover to Backfiller resource
sisyphusSmiling 4e99430
add coverage.lcov to .gitignore
sisyphusSmiling c3d8cca
re-add early return to optimize common case
sisyphusSmiling ed762d8
rewrap contract comments
sisyphusSmiling 466bed8
Merge pull request #418 from onflow/giovanni/fix-sor-history
tarakby a11baea
update .borrowBackfiller() access & add event test coverage
sisyphusSmiling bd2265f
tests: add non-continuous gaps events check and use backfilling constant
tarakby 75d3500
PR review: use array length to compare with empty array and minor cha…
tarakby b181bc3
make generate
tarakby a14b5e2
optimize unnecessary function calls
tarakby e913f3a
minor optimization
tarakby File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for adding 2 events and not only
RandomHistoryBackfilled
is the edge case specifically mentioned in the comment.If that edge case happens while only emitting
RandomHistoryBackfilled
, there is no clear way to know what exact indices got backfilled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the suggested event definition from https://github.com/bluesign/flow-core-contracts/blob/randomBackfill/contracts/RandomBeaconHistory.cdc