Upgrade flow-go (to include FVM logging API change) #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Sep 1, 2022
3117: [FVM] Cleanup fvm logging r=janezpodhostnik a=janezpodhostnik Setup the context log in the computer to already have transaction fields on it. Use only the logger from the FVM context in the FVM. This is a breaking change for the emulator onflow/flow-emulator#195 This might also break any code dependent on the logs as we were previously not consistent and used both "tx_id" and "txHash" to log the tx id. Grafana dashboards come to mind. Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Sep 1, 2022
3117: [FVM] Cleanup fvm logging r=janezpodhostnik a=janezpodhostnik Setup the context log in the computer to already have transaction fields on it. Use only the logger from the FVM context in the FVM. This is a breaking change for the emulator onflow/flow-emulator#195 This might also break any code dependent on the logs as we were previously not consistent and used both "tx_id" and "txHash" to log the tx id. Grafana dashboards come to mind. Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
janezpodhostnik
requested review from
sideninja,
psiemens and
turbolent
as code owners
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 49.46% 49.46%
=======================================
Files 30 30
Lines 2434 2434
=======================================
Hits 1204 1204
Misses 1086 1086
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sideninja
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a change in the logging API for the FVM: onflow/flow-go#3117
This PR upgrades flow-go to that version
For contributor use:
masterbranchFiles changedin the GitHub PR explorer