Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire memstore, user badger InMemory option instead #203

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

bluesign
Copy link
Collaborator

Closes #83 and #202

Description

Very nice memory usage vs memstore.

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #203 (9a70cd4) into master (c3d473d) will increase coverage by 1.88%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   49.52%   51.41%   +1.88%     
==========================================
  Files          30       29       -1     
  Lines        2441     2338     -103     
==========================================
- Hits         1209     1202       -7     
+ Misses       1088      991      -97     
- Partials      144      145       +1     
Flag Coverage Δ
unittests 51.41% <46.66%> (+1.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/badger/config.go 46.15% <33.33%> (-9.41%) ⬇️
blockchain.go 75.12% <50.00%> (-0.22%) ⬇️
server/server.go 50.78% <100.00%> (+0.78%) ⬆️
server/storage.go 50.00% <100.00%> (+44.28%) ⬆️
server/grpc.go 51.85% <0.00%> (-14.82%) ⬇️
server/admin.go 47.05% <0.00%> (-4.95%) ⬇️
server/rest.go 41.66% <0.00%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@bluesign
Copy link
Collaborator Author

bluesign commented Oct 7, 2022

@turbolent @psiemens @janezpodhostnik Any chance to review this? I have couple of PRs accidentally branched on this one, if this is merged, will make my life much easier

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@sideninja sideninja merged commit ddc2f1c into onflow:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Placeholder] Performance issues with large amount of transactions
4 participants