Update fvm api calls #306
Merged
Update fvm api calls #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattyshack
added
the
Improvement
pattyshack
requested review from
sideninja,
turbolent,
janezpodhostnik and
bluesign
as code owners
pattyshack
force-pushed
the
patrick/update-fvm-api
branch
from
0a8f53b
to
ba1f137
Compare
|
@pattyshack thank you so much for |
bluesign
reviewed
Jan 28, 2023
Comment on lines
+1043
to
+1049
| derivedBlockData := derived.NewEmptyDerivedBlockData() | ||
| derivedTxnData, err := derivedBlockData.NewSnapshotReadDerivedTransactionData( | ||
| derived.EndOfBlockExecutionTime, | ||
| derived.EndOfBlockExecutionTime) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
nit, maybe some method like derived.NewEmptyDerivedTransactionData() in the future to fvm?
There was a problem hiding this comment.
you're using an internal api here. if you're using the fvm public interface, these are optional
There was a problem hiding this comment.
hmm I didn't know you can do this via fvm public interfaces. let me have a look and make a PR, thanks @pattyshack
There was a problem hiding this comment.
i don't think there's an equivalent public interface. i'm just pointing out that fvm is designed around the VM (Run) interface in general
There was a problem hiding this comment.
ah ok got it thanks, though probably I still can workaround fvm here.
bluesign
approved these changes
Jan 28, 2023
sideninja
reviewed
Jan 30, 2023
| fvmOptions = append(fvmOptions, fvm.WithTransactionProcessors(fvm.NewTransactionInvoker())) | ||
| fvmOptions = append( | ||
| fvmOptions, | ||
| fvm.WithAuthorizationChecksEnabled(false), |
There was a problem hiding this comment.
Should we also add WithAccountKeyWeightThreshold with negative value to skip signature verification? cc @bluesign
There was a problem hiding this comment.
I think as of flow-go master today not necessary.
sideninja
approved these changes
Jan 30, 2023
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Feb 7, 2023
3895: Merge `feature/active-pacemaker` to `master` r=jordanschalm a=jordanschalm This PR merges the Active Pacemaker feature branch to `master`, after which we can delete the branch. - In the unlikely case of a need to revert to pre-Jolteon consensus during the current spork, we have `v0.29-no-pacemaker` ### Files with merge conflicts ``` CONFLICT (content): Merge conflict in cmd/Dockerfile CONFLICT (content): Merge conflict in consensus/hotstuff/eventhandler/event_handler_test.go CONFLICT (content): Merge conflict in consensus/hotstuff/integration/instance_test.go CONFLICT (content): Merge conflict in consensus/integration/integration_test.go CONFLICT (content): Merge conflict in engine/common/follower/engine.go CONFLICT (content): Merge conflict in engine/consensus/compliance/core.go CONFLICT (content): Merge conflict in engine/execution/computation/computer/computer_test.go CONFLICT (content): Merge conflict in go.mod CONFLICT (content): Merge conflict in insecure/go.mod CONFLICT (content): Merge conflict in integration/go.mod CONFLICT (content): Merge conflict in module/metrics.go CONFLICT (content): Merge conflict in module/metrics/noop.go CONFLICT (content): Merge conflict in storage/mock/headers.go CONFLICT (content): Merge conflict in storage/mocks/storage.go ``` ### Additional Commits - 5277860 (`make tidy`) - aa61441 (`make generate-mocks`) - 7908418 0110499 39bc9b0 (pin version of `flow-emulator` which includes PRs below) - onflow/flow-emulator#275 - onflow/flow-emulator#306 - onflow/flow-emulator#311 - bb91d34 (`make tidy` again) - 8e71b43 Merge `master`, resolve new conflicts in `engine/execution/computation/computer/computer_test.go` - d75481c Pin version of `onflow/flow` which includes Header model changes for Pacemaker - f46be69 Fix header whitespace (`goimports`) See [7e24c7d...bb91d34](https://github.com/onflow/flow-go/pull/3895/files/7e24c7db89f89e4b250415fd35dbce0618213434..bb91d34cbc1caeeec807dbe96c15ccb15a7b7a30), [d75481c...f46be69](https://github.com/onflow/flow-go/pull/3895/files/d75481c2b41769c912858eb4bbbce33ae5d09131..f46be69140ab1af6c9501e13676f872572242ccd) for a diff of all post-merge changes. Co-authored-by: Jordan Schalm <jordan@dapperlabs.com> Co-authored-by: Yurii Oleksyshyn <yuraolex@gmail.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Feb 7, 2023
3895: Merge `feature/active-pacemaker` to `master` r=jordanschalm a=jordanschalm This PR merges the Active Pacemaker feature branch to `master`, after which we can delete the branch. - In the unlikely case of a need to revert to pre-Jolteon consensus during the current spork, we have `v0.29-no-pacemaker` ### Files with merge conflicts ``` CONFLICT (content): Merge conflict in cmd/Dockerfile CONFLICT (content): Merge conflict in consensus/hotstuff/eventhandler/event_handler_test.go CONFLICT (content): Merge conflict in consensus/hotstuff/integration/instance_test.go CONFLICT (content): Merge conflict in consensus/integration/integration_test.go CONFLICT (content): Merge conflict in engine/common/follower/engine.go CONFLICT (content): Merge conflict in engine/consensus/compliance/core.go CONFLICT (content): Merge conflict in engine/execution/computation/computer/computer_test.go CONFLICT (content): Merge conflict in go.mod CONFLICT (content): Merge conflict in insecure/go.mod CONFLICT (content): Merge conflict in integration/go.mod CONFLICT (content): Merge conflict in module/metrics.go CONFLICT (content): Merge conflict in module/metrics/noop.go CONFLICT (content): Merge conflict in storage/mock/headers.go CONFLICT (content): Merge conflict in storage/mocks/storage.go ``` ### Additional Commits - 5277860 (`make tidy`) - aa61441 (`make generate-mocks`) - 7908418 0110499 39bc9b0 (pin version of `flow-emulator` which includes PRs below) - onflow/flow-emulator#275 - onflow/flow-emulator#306 - onflow/flow-emulator#311 - bb91d34 (`make tidy` again) - 8e71b43 Merge `master`, resolve new conflicts in `engine/execution/computation/computer/computer_test.go` - d75481c Pin version of `onflow/flow` which includes Header model changes for Pacemaker - f46be69 Fix header whitespace (`goimports`) See [7e24c7d...bb91d34](https://github.com/onflow/flow-go/pull/3895/files/7e24c7db89f89e4b250415fd35dbce0618213434..bb91d34cbc1caeeec807dbe96c15ccb15a7b7a30), [d75481c...f46be69](https://github.com/onflow/flow-go/pull/3895/files/d75481c2b41769c912858eb4bbbce33ae5d09131..f46be69140ab1af6c9501e13676f872572242ccd) for a diff of all post-merge changes. Co-authored-by: Jordan Schalm <jordan@dapperlabs.com> Co-authored-by: Yurii Oleksyshyn <yuraolex@gmail.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #???
Description
For contributor use:
masterbranchFiles changedin the GitHub PR explorer