Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing streaming methods #658

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement missing streaming methods #658

wants to merge 1 commit into from

Conversation

bluesign
Copy link
Collaborator

@bluesign bluesign commented May 2, 2024 •
edited
Loading

Closes #657

Description

Implements new streaming methods, not sure if it is need to back port this.

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@bluesign
Copy link
Collaborator Author

bluesign commented May 7, 2024

@peterargue can you have a look? I want to be 100% sure what I did is correct before requesting a review.

@bluesign bluesign mentioned this pull request May 7, 2024
Merged
peterargue
peterargue reviewed May 10, 2024
View reviewed changes
server/access/streamBackend.go
isNotFound := errors.As(err, &blockNotFoundByIDError)
if !isNotFound {
//check latest block request
if blockID != flow.ZeroID && height == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend switching this to use the new start height approach. this older approach requires more complicated client and server side logic and makes it hard to stream from block 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterargue peterargue peterargue left review comments

@sideninja sideninja Awaiting requested review from sideninja sideninja will be requested when the pull request is marked ready for review sideninja is a code owner

@turbolent turbolent Awaiting requested review from turbolent turbolent will be requested when the pull request is marked ready for review turbolent is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik will be requested when the pull request is marked ready for review janezpodhostnik is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming will be requested when the pull request is marked ready for review chasefleming is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink will be requested when the pull request is marked ready for review jribbink is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new state streaming endpoints
2 participants
@bluesign @peterargue