Merge #1331

1331: Reorder middleware error checking code r=huitseeker a=smnzhu

We should check the error returned from libp2pNodeFactory before doing anything else

Co-authored-by: Simon Zhu <simon.zsiyan@gmail.com>

network/p2p/middleware.go

@@ -232,17 +232,16 @@ func (m *Middleware) UpdateNodeAddresses() {
 func (m *Middleware) Start(ov network.Overlay) error {
 	m.ov = ov
 	libP2PNode, err := m.libP2PNodeFactory()
-
-	if m.idProvider == nil {
-		m.idProvider = NewPeerstoreIdentifierProvider(m.log, libP2PNode.host, m.idTranslator)
-	}
-
 	if err != nil {
 		return fmt.Errorf("could not create libp2p node: %w", err)
 	}
 	m.libP2PNode = libP2PNode
 	m.libP2PNode.SetFlowProtocolStreamHandler(m.handleIncomingStream)
 
+	if m.idProvider == nil {
+		m.idProvider = NewPeerstoreIdentifierProvider(m.log, m.libP2PNode.host, m.idTranslator)
+	}
+
 	m.UpdateNodeAddresses()
 
 	if m.connectionGating {