Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder middleware error checking code #1331

Merged
merged 2 commits into from Sep 22, 2021
Merged

Conversation

synzhu
Copy link
Contributor

@synzhu synzhu commented Sep 22, 2021

We should check the error returned from libp2pNodeFactory before doing anything else

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks!

@codecov-commenter
Copy link

Codecov Report

Merging #1331 (b61ecd0) into master (f3f78f5) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1331      +/-   ##
==========================================
+ Coverage   56.19%   56.21%   +0.02%     
==========================================
  Files         500      500              
  Lines       31072    31072              
==========================================
+ Hits        17460    17468       +8     
+ Misses      11247    11236      -11     
- Partials     2365     2368       +3     
Flag Coverage Δ
unittests 56.21% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
network/p2p/middleware.go 0.00% <0.00%> (ø)
...sus/approvals/assignment_collector_statemachine.go 50.00% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f78f5...b61ecd0. Read the comment docs.

@huitseeker
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 22, 2021

@bors bors bot merged commit 864fc75 into master Sep 22, 2021
@bors bors bot deleted the reorder-middleware-error branch September 22, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants