Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back port state migration bug fix to master #1336

Merged
merged 1 commit into from Sep 29, 2021

Conversation

Kay-Zee
Copy link
Member

@Kay-Zee Kay-Zee commented Sep 22, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1336 (360f818) into master (864fc75) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   56.23%   56.19%   -0.05%     
==========================================
  Files         500      500              
  Lines       31072    31079       +7     
==========================================
- Hits        17474    17465       -9     
- Misses      11232    11249      +17     
+ Partials     2366     2365       -1     
Flag Coverage Δ
unittests 56.19% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/util/cmd/execution-state-extract/cmd.go 56.25% <0.00%> (ø)
module/chunks/chunk_assigner.go 58.97% <0.00%> (ø)
module/validation/seal_validator.go 76.10% <50.00%> (-0.75%) ⬇️
state/protocol/badger/snapshot.go 57.32% <66.66%> (ø)
module/builder/consensus/builder.go 70.03% <100.00%> (+0.23%) ⬆️
...sus/approvals/assignment_collector_statemachine.go 42.30% <0.00%> (-9.62%) ⬇️
...ngine/common/synchronization/finalized_snapshot.go 68.75% <0.00%> (-4.17%) ⬇️
admin/command_runner.go 78.51% <0.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2752f4...360f818. Read the comment docs.

@peterargue
Copy link
Contributor

this seems pretty straight forward, but can you link to the original PR/commit that contains more context about what this change is fixing?

@huitseeker
Copy link
Contributor

This is also true for #1335 and the source is probably fab4fb1.

@Kay-Zee
Copy link
Member Author

Kay-Zee commented Sep 29, 2021

bors merge

bors bot added a commit that referenced this pull request Sep 29, 2021
1336: Back port state migration bug fix to master r=Kay-Zee a=Kay-Zee



Co-authored-by: Kay-Zee <kan@axiomzen.co>
@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

Build failed:

@Kay-Zee
Copy link
Member Author

Kay-Zee commented Sep 29, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

@bors bors bot merged commit a9f4b27 into master Sep 29, 2021
@bors bors bot deleted the kan/fix-state-migration-cmd-master branch September 29, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants