quarantine flaky test TestStreamClosing

[AlexHentschel]

Requesting to quarantine flaky test

flow-go/network/p2p/libp2pNode_test.go

Line 467 in 696ea97

func (suite *LibP2PNodeTestSuite) TestStreamClosing() {

• In the majority of CI runs, the assertion

  flow-go/network/p2p/libp2pNode_test.go

  Lines 485 to 486 in 696ea97

  	err := s.Close()
  	assert.NoError(t, err)

  fails

Added test to the quarantine list: https://www.notion.so/dapperlabs/TestStreamClosing-6dec4ecfee144bd69f7606a0398e5273

[codecov-commenter]

Codecov Report

Merging #1351 (a24fea2) into master (28a6922) will increase coverage by 0.02%.
The diff coverage is 53.40%.

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
+ Coverage   56.25%   56.28%   +0.02%     
==========================================
  Files         500      502       +2     
  Lines       31162    31208      +46     
==========================================
+ Hits        17531    17564      +33     
- Misses      11262    11272      +10     
- Partials     2369     2372       +3     

Flag	Coverage Δ
unittests	56.28% <53.40%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
consensus/config.go	0.00% <0.00%> (ø)
consensus/participant.go	15.95% <0.00%> (ø)
model/flow/role.go	89.36% <ø> (ø)
network/p2p/middleware.go	0.00% <0.00%> (ø)
network/test/testUtil.go	94.90% <ø> (ø)
network/topology/helper.go	82.35% <ø> (-1.86%)	⬇️
network/p2p/libp2pNode.go	65.45% <30.76%> (-1.11%)	⬇️
network/p2p/subscription_filter.go	47.82% <47.82%> (ø)
network/topology/randomizedTopology.go	66.07% <50.00%> (ø)
network/topology/topicBasedTopology.go	71.25% <50.00%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba7bcb...a24fea2. Read the comment docs.

[yhassanzadeh13]

@AlexHentschel issued up here to fix:https://github.com/dapperlabs/flow-go/issues/5882

[gomisha]

LGTM

[huitseeker]

bors merge

[bors]

Build succeeded:

• Integration Tests (1.15)
• Integration Tests (1.16)
• Lint
• Unit Tests (1.15)
• Unit Tests (1.16)