Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarantine flaky test TestStreamClosing #1351

Merged
merged 4 commits into from
Sep 29, 2021
Merged

quarantine flaky test TestStreamClosing #1351

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
696ea97
quarantined flaky test TestStreamClosing
Sep 24, 2021
04d9883
Merge branch 'master' into alex/quarantining_flaky_test_TestStreamClo…
Sep 27, 2021
a24fea2
Merge branch 'master' into alex/quarantining_flaky_test_TestStreamClo…
Sep 27, 2021
60e34fe
Merge branch 'master' into alex/quarantining_flaky_test_TestStreamClo…
Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions network/p2p/libp2pNode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,7 @@ func (suite *LibP2PNodeTestSuite) TestCreateStreamIsConcurrencySafe() {

// TestStreamClosing tests 1-1 communication with streams closed using libp2p2 handler.FullClose
func (suite *LibP2PNodeTestSuite) TestStreamClosing() {
suite.T().Skip("QUARANTINED as FLAKY: closing network.Stream.Close() often errors in handler function, thereby failing this test")

count := 10
ch := make(chan string, count)
Expand Down