Bootstrapping Generates Root Snapshot File #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danuio
changed the base branch from
master
to
feature/serializable-snapshots
There was a problem hiding this comment.
For this lint error, needs to do serializable.Encodable(). inmem.Snapshot implements protocol.Snapshot but is not directly serializable, inmem.EncodableSnapshot has all the exported fields needed to be serialized from another package.
For this error, it is fixed in this PR #374
|
We will also need to update the I have added some more detail to the issue regarding the final step of this ticket:
|
…-root-snapshot-bootstrap
…-root-snapshot-bootstrap
…-root-snapshot-bootstrap
…om:onflow/flow-go into danu/5286/generate-root-snapshot-bootstrap
…om:onflow/flow-go into danu/5286/generate-root-snapshot-bootstrap
vishalchangrani
approved these changes
Apr 5, 2021
…om:onflow/flow-go into danu/5286/generate-root-snapshot-bootstrap
This commit is a reference point for reproducing inconsistent sealing behaviour between integration tests (TestMVP_Bootstrap) and localnet. Localnet can be started, then restarted, and sealing will continue. (This is without submitting any transactions.) make init && make start make stop && make start The TestMVP_Bootstrap integration test (which does the same network restart automatically) fails to seal any blocks after the network is restarted.
This reverts commit 6a3bb95.
…/5286-bootstrap-test
Update bootstrap MVP integration test
jordanschalm
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dapperlabs/flow-go/issues/5286.