Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bootstrap MVP integration test #619

Merged
merged 11 commits into from
Apr 16, 2021
Merged

Update bootstrap MVP integration test #619

merged 11 commits into from
Apr 16, 2021

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Apr 12, 2021 •
edited

This PR makes some modifications to the BootstrapMVP integration tests created in #537:

  • Create a separate bootstrap directory for each node in integration tests
    • This is necessary to restart individual nodes with different bootstrapping files, and will be necessary for epoch-spanning integration tests down the line
  • Modify BootstrapMVP test to only restart one consensus node with the non-genesis root snapshot
    • we can't wipe the DB and restart with the non-genesis root snapshot mid-epoch for collection nodes or execution nodes, because they both have local state not captured in the protocol state (cluster chain and execution state)

Despite these updates, as it stands, there are two blockers to getting this test passing:

  1. Channel namespacing needs to be modified for epochs https://github.com/dapperlabs/flow-go/issues/5433
  2. Sealing inconsistency between testnet and localnet https://github.com/dapperlabs/flow-go/issues/5451

Because of these, I suggest we merge this PR and #424 (with TestMVP_Bootstrap skipped) into the feature branch and revisit the test when the blockers are resolved.

@jordanschalm jordanschalm changed the title WIP: Fixing integration test WIP: Fixing bootstrap integration test Apr 12, 2021
@jordanschalm jordanschalm changed the title WIP: Fixing bootstrap integration test Update bootstrap MVP integration test Apr 14, 2021
@jordanschalm jordanschalm marked this pull request as ready for review April 14, 2021 23:12
jordanschalm and others added 5 commits April 14, 2021 16:36
@jordanschalm
reference commit for sealing inconsistency after restart
6a3bb95 
This commit is a reference point for reproducing inconsistent sealing
behaviour between integration tests (TestMVP_Bootstrap) and localnet.

Localnet can be started, then restarted, and sealing will continue.
(This is without submitting any transactions.)
make init && make start
make stop && make start

The TestMVP_Bootstrap integration test (which does the same network restart
automatically) fails to seal any blocks after the network is restarted.
@jordanschalm
Revert "reference commit for sealing inconsistency after restart"
301a9cb 
This reverts commit 6a3bb95.
@jordanschalm
skip mvp bootstrap test with link to blocker
6309ead
@danuio
Fix linting
d381562
@danuio
Merge branch 'danu/5286/generate-root-snapshot-bootstrap' into jordan…
63f66ff 
…/5286-bootstrap-test
@jordanschalm jordanschalm merged commit d5852bd into danu/5286/generate-root-snapshot-bootstrap Apr 16, 2021
@jordanschalm jordanschalm deleted the jordan/5286-bootstrap-test branch April 16, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrivets arrivets arrivets approved these changes

@danuio danuio danuio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jordanschalm @arrivets @danuio