-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFM] Transition to committed epoch in EFM #5898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/efm-recovery #5898 +/- ##
========================================================
- Coverage 57.63% 55.61% -2.03%
========================================================
Files 867 1134 +267
Lines 68038 89665 +21627
========================================================
+ Hits 39217 49868 +10651
- Misses 25129 34997 +9868
- Partials 3692 4800 +1108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice and clean code 👏 . Its exciting to see the puzzle pieces coming together.
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
…t.go Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
…w/flow-go into yurii/5726-maintaining-efm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
#5726
Context
Previously we could maintain EFM only if we have entered it in staking or setup phases, if we have entered EFM when next epoch has been already committed then we wouldn't perform epoch transition because
FallbackStateMachine
ignored request for transition to the next epoch.This PR updates
FallbackStateMachine
to use the same logic for epoch transitions as the happy path. Additionally activated previously disabled tests and restructured logic.