Update to Cadence v0.15.1 and Go SDK v0.18.0, Add balance fields to AuthAccount and PublicAccount #636
Conversation
|
Looks good! Is there a particular reason this PR also removes the state migrations? Totally agree with removing them, was just curious. In case it's not related maybe a separate PR would be nice, but minor |
turbolent
changed the title
utils/unittest/execution_state.go
Outdated
| @@ -19,7 +19,7 @@ import ( | |||
| const ServiceAccountPrivateKeyHex = "e3a08ae3d0461cfed6d6f49bfc25fa899351c39d1bd21fdba8c87595b6c49bb4cc430201" | |||
|
|
|||
| // Pre-calculated state commitment with root account with the above private key | |||
| const GenesisStateCommitmentHex = "344eb8ba50c683c1d9d5662afb8800f641518bc8349bf2427cb919e7f7a95edb" | |||
| const GenesisStateCommitmentHex = "66d3604b5d9c458c7e72a59a9e10064b89d1d6657ce59954963305417460ea1f" | |||
There was a problem hiding this comment.
This doesn't seem right, I don't think we have changed anything that should impact the statecommitment of the genesis? or did we?
There was a problem hiding this comment.
See the description of the issue, Cadence v0.15.0 changed the storage format
|
@joshuahannan do you know if there's now a tag available for the core contracts that includes onflow/flow-core-contracts#159 ? |
|
@turbolent No, but I'll do a new release so you can get it |
|
@joshuahannan perfect, thanks! Please let me know when it's ready and I can update this PR |
|
@ramtinms the revert of the multi-contract state migration re-introduced a breaking test, it assumes that the Cadence version is able to decode the test's data, but it's in the now deprecated format. |
ref: https://github.com/dapperlabs/flow-internal/issues/1499
Release notes:
This release changes the storage format. Add state migration for new Cadence storage format v4 #638 implements the storage migration function for that
Before merging: