Add state migration for new Cadence storage format v4 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
reviewed
Apr 19, 2021
| error | ||
| }) | ||
|
|
||
| workerCount := runtime.NumCPU() |
There was a problem hiding this comment.
does this work on GCP virtual machine env?
There was a problem hiding this comment.
I guess so, do you have any concerns why it would not?
ramtinms
approved these changes
Apr 19, 2021
This was referenced Apr 21, 2021
turbolent
force-pushed
the
bastian/cadence-storage-format-v4-state-migration
branch
from
dca2a5e
to
4b76e41
Compare
|
@ramtinms What do you mean with "rencodeValueV4 is inclusive"? |
Kay-Zee
approved these changes
Apr 22, 2021
|
Ah, OK, thank you! I'll re-run CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dapperlabs/flow-go#5422
The next Cadence release will introduce a new storage format, which means the whole execution state needs to be migrated from an old format (there are multiple older versions) to the new format.
Implement a state migration function which decodes all Cadence values using the old decoder and encodes them using the new encoder.
As a sanity check, the newly encoded data is re-decoded, and the resulting value is compared to the value which was initially decoded from the original data using the old decoder.