Rate limit by payer account #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanschalm
requested review from
vishalchangraniaxiom-old,
Kay-Zee and
zhangchiqing
jordanschalm
changed the title
|
|
the main function was already too big before adding rate limiting, this at least mvoes some logic outside
tarakby
reviewed
Oct 19, 2020
tarakby
approved these changes
Oct 19, 2020
| // remove from mempool, conflicts with finalized block will never be valid | ||
| b.transactions.Rem(txID) | ||
| continue | ||
| } | ||
|
|
||
| // enforce rate limiting rules | ||
| if limiter.shouldRateLimit(tx) { |
There was a problem hiding this comment.
I am guessing rate limiting a tx would be an exception vs a norm and if that is the case then should we log.debug the tx and payer we rate limited to figure out who is abusing the system from logs?
There was a problem hiding this comment.
Alternatively, we could add a metric later "rate_limited_tx".
There was a problem hiding this comment.
Good point. I won't have time before the spork we're trying to get this in for, but I'll add a note to the other issue.
vishalchangrani
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://github.com/dapperlabs/flow-go/issues/4909
This PR implements rate limiting on transaction payer accounts. It adds two new configuration options to the collection builder module, a max rate which limits the rate at which transactions for any given payer account are included, and a set of unlimited payers which are not hindered by the rate limiting.
We do not add this rate limiting to the
Mutatormodule because this is not part of the protocol, and inconsistent configuration between collection nodes could lead to finalization problems if we did. Conceptually this is an optional feature that is enabled and enforced independently on each collection node. When all collection nodes select the same rate limit the effect is an equivalent network-wide rate limit.Usage
NBA/Dapper use one payer account, on mainnet we should set the flag
builder-unlimited-payers=<DAPPER_ADDR>. When setting the rate limit, note that the limiting is enforced on a per-cluster basis, so the number of clusters should be factored into choosing that value.