New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limit by payer account #67
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
946844b
use separate config for collection builder
jordanschalm 2701aa9
add test cases for rate limiting
jordanschalm b314e51
rate limiting test cases
jordanschalm 0a22213
implement rate limiting
jordanschalm 8bdabc8
use 3 collection nodes by default
jordanschalm cc81c46
add flags for rate limiting config
jordanschalm 6969c9f
remove comments
jordanschalm 7b06ddb
refactor tx duplication and rate limiting
jordanschalm f4b2501
moving code around + adding comments
jordanschalm 01c74f0
fix a bad IDE auto-rename
jordanschalm 9eb1f3e
remove unused method
jordanschalm dd0d566
use 64bytes in signature fixtures
jordanschalm bdf8458
Merge branch 'master' into jordan/4909-acct-rate-limiting
jordanschalm File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
COLLECTION = 1 | ||
COLLECTION = 3 | ||
CONSENSUS = 3 | ||
EXECUTION = 1 | ||
VERIFICATION = 1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing rate limiting a tx would be an exception vs a norm and if that is the case then should we log.debug the tx and payer we rate limited to figure out who is abusing the system from logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we could add a metric later "rate_limited_tx".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I won't have time before the spork we're trying to get this in for, but I'll add a note to the other issue.