Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cadence Update #879

Merged
merged 20 commits into from
Jun 24, 2021
Merged

Cadence Update #879

merged 20 commits into from
Jun 24, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jun 21, 2021

Update cadence to newest version

@janezpodhostnik janezpodhostnik changed the base branch from auto-cadence-upgrade/bastian/string-format to master June 23, 2021 14:10
@janezpodhostnik janezpodhostnik changed the title Auto Cadence Update: FlowKit API Update Cadence Update Jun 23, 2021
@turbolent
Copy link
Member Author

Thank you for the fixes @janezpodhostnik! I guess the state commitment change is due to the result of interpreter.StringValue.String() now being different?

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #879 (ac926b6) into master (fef3bdd) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #879      +/-   ##
==========================================
+ Coverage   56.86%   56.89%   +0.02%     
==========================================
  Files         429      429              
  Lines       25635    25635              
==========================================
+ Hits        14577    14584       +7     
+ Misses       9083     9079       -4     
+ Partials     1975     1972       -3     
Flag Coverage Δ
unittests 56.89% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
engine/verification/match/chunks.go 83.33% <0.00%> (-6.67%) ⬇️
module/mempool/epochs/transactions.go 94.73% <0.00%> (-5.27%) ⬇️
engine/verification/match/engine.go 65.10% <0.00%> (-1.08%) ⬇️
cmd/util/ledger/migrations/storage_v4.go 41.56% <0.00%> (-0.61%) ⬇️
engine/execution/ingestion/engine.go 57.46% <0.00%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef3bdd...ac926b6. Read the comment docs.

@janezpodhostnik
Copy link
Contributor

There was a core contracts upgrade as well...

@turbolent
Copy link
Member Author

turbolent commented Jun 23, 2021

Ah, I see! 👍

Just curious: Why was it upgraded?

@janezpodhostnik
Copy link
Contributor

Good question! I incorrectly assumed that it came together with the cadence upgrade. I have removed the core-contract upgrade.

@turbolent turbolent merged commit 9b26087 into master Jun 24, 2021
@turbolent turbolent deleted the auto-cadence-upgrade/gregor/flowkit-update branch June 24, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants