Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get account issue 182 #186

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Fix get account issue 182 #186

merged 3 commits into from
Sep 19, 2022

Conversation

justinbarry
Copy link
Contributor

Closes #182

@justinbarry justinbarry requested a review from a team as a code owner September 19, 2022 18:47
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: 696cd3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adbario
Copy link
Contributor

adbario commented Sep 19, 2022

Nice one @justinbarry 👍

I've also added earlier today a PR to fix this, just with a slightly different approach #185

@justinbarry justinbarry merged commit c862a91 into master Sep 19, 2022
@justinbarry justinbarry deleted the fix-get-account-issue-182 branch September 19, 2022 19:51
@justinbarry
Copy link
Contributor Author

@adbario Whoa, thanks! Didn't catch yours in time. Commented on your other one. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getAccountAddress() broken - could be dependency issue
3 participants