Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass interaction props through logger #185

Closed
wants to merge 1 commit into from

Conversation

adbario
Copy link
Contributor

@adbario adbario commented Sep 19, 2022

Closes #182

Description

Fixes the underlying issue behind getAccountAddress not working on 0.3.0-alpha.15 where the interaction logging was introduced.

As stated in #182 (comment), the issue exists because of how Microbundle handles async function arguments. This issue has likely not been noticed as the tests in the example folder use the source files instead of the bundled ones.

The issue is fixed by passing the interaction props through the logger back to the transactions and scripts.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation (no relevant documentation)
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@adbario adbario requested a review from a team as a code owner September 19, 2022 18:06
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

⚠️ No Changeset found

Latest commit: bb4cb6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@justinbarry
Copy link
Contributor

Oh man, sadly I just fixed this. I really appreciate you looking into it!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getAccountAddress() broken - could be dependency issue
2 participants