-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Upgrade transaction for Staking contract #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there are a few differences between the PR (onflow/flow-core-contracts#321) and transactions/update-contract/2023/feb-1/FlowIDTableStaking.cdc
. don't forget to pull those in
let approveList: [String] = stakingAccount.load<[String]>(from: /storage/idTableApproveList) | ||
?? panic("Could not load the approve list from storage") | ||
|
||
// Create the approve list dictionary with the loaded value, then store the dictionary in the same path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approveDict
doesn't appear to be stored anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this was just a draft. I've tested the transaction now and updated it
@vishalchangrani @Kay-Zee I've added the instructions to the README for doing the multisign with the staking account and service account. Can y'all take a look and let me know if the instructions look good? Thanks! |
flow transactions build ./templates/upgrade_nodelists.cdc \ | ||
--config-path flow-staking.json \ | ||
--network mainnet \ | ||
--args-json "$(cat "./transactions/update-contract/2023/feb-8/arguments-update-contract-FlowIDTableStaking-mainnet.json")" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the RLP generation and then tried to sign the generated transaction and ran into this issue:
I executed:
|
@janezpodhostnik would you know? |
fixing path to transaction cdc file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the command to build, sign and send the transactions. Found an issue with Flow cli which has not been fixed. Flow cli needs to be updated to v0.45.2.
…ulti-sign call tomorrow
Adds contract, transaction, and arguments for the upgrade to the FlowIDTableStaking contract on mainnet