Flow CLI integration module #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
# Conflicts: # frontend/src/components/navigation/Navigation.tsx # frontend/src/targets/electron/backend.ts # frontend/src/targets/electron/main.ts
bartolomej
previously approved these changes
Nov 15, 2022
bartolomej
previously approved these changes
Nov 18, 2022
pkg/flowser/app.go
Outdated
| projectPath = fmt.Sprintf("--project-path=%s", projectPath) | ||
| } | ||
|
|
||
| return exec. |
There was a problem hiding this comment.
I noticed that the child process (Flowser) keeps running on Windows after you kill the parent (go program).
I'm not sure why that's the case, but it seems to be the default behavior on Windows. Here is the orphan process info:
There was a problem hiding this comment.
This is probably not the highest priority, so we can fix this at some later point.
There was a problem hiding this comment.
Very good point!
bartolomej
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and improve the Go module used to be integrated in other tools such as Flow CLI.
Currently implemented functions: